Fix nested ternary operator indentation issue#62537
Closed
harshith1118 wants to merge 2 commits intomicrosoft:mainfrom
Closed
Fix nested ternary operator indentation issue#62537harshith1118 wants to merge 2 commits intomicrosoft:mainfrom
harshith1118 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
|
Your before and after look the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the indentation issue with nested ternary expressions in TypeScript code. Previously, nested
ternary operations were getting increasingly indented, causing poor readability. This change ensures that
nested ternary expressions align at the same indentation level, improving code formatting consistency.
Details
The fix modifies the logic in src/services/formatting/smartIndenter.ts within the
childIsUnindentedBranchOfConditionalExpression function. Previously, when handling nested ternary
expressions (conditional expressions), the formatter was not properly handling the alignment of subsequent
ternary operations in a chain.
Before:
1 var current =
2 0 ? 1 :
3 2 ? 3 :
4 4;
After:
1 var expected =
2 0 ? 1 :
3 2 ? 3 :
4 4;
Tests
Code Review