Fix completions at type-only export specifiers#62651
Fix completions at type-only export specifiers#62651Andarist wants to merge 1 commit intomicrosoft:mainfrom
export specifiers#62651Conversation
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
| //// | ||
| //// export { M/*6*/ } from "./m1" | ||
| //// export type { M/*7*/ } from "./m1" | ||
| //// export { type M/*8*/ } from "./m1" |
There was a problem hiding this comment.
Fixing this is the main goal of this PR. At the moment, on the main branch this errors with:
Error: At marker '8': No completions at position '232'
| // import { type foo| } | ||
| return containingNodeKind !== SyntaxKind.ImportSpecifier; | ||
| // export { type foo| } | ||
| return !isImportOrExportSpecifier(parent); |
There was a problem hiding this comment.
This is the only change needed to accomplish the goal of this PR. I threw in the rest of the changes to fix some redundant type keyword completions (all of that is reflected by the tests I added)
| case SyntaxKind.ExportSpecifier: | ||
| return (node as ExportSpecifier).isTypeOnly || (node as ExportSpecifier).parent.parent.isTypeOnly; | ||
| case SyntaxKind.ExportDeclaration: | ||
| return (node as ExportDeclaration).isTypeOnly && !!(node as ExportDeclaration).moduleSpecifier && !(node as ExportDeclaration).exportClause; |
There was a problem hiding this comment.
Those extra requirements were quite odd here (and got in a way of the tests I was adding for type keyword inclusion/exclusion). An export declaration should be treated as type-only regardless of the existence of other fields on that export declaration AST node. The introduced change also matches the import-oriented counterpart of the containing function (isTypeOnlyImportDeclaration) where there are no extra conditions in the SyntaxKind.ImportSpecifier case.
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
3 participants
see https://github.com/microsoft/TypeScript/pull/62651/files#r2449778554