Fixed a crash when parsing invalid decorator on await expression#62659
Merged
RyanCavanaugh merged 2 commits intomicrosoft:mainfrom Oct 22, 2025
Merged
Fixed a crash when parsing invalid decorator on await expression#62659RyanCavanaugh merged 2 commits intomicrosoft:mainfrom
RyanCavanaugh merged 2 commits intomicrosoft:mainfrom
Conversation
RyanCavanaugh
approved these changes
Oct 22, 2025
auto-merge was automatically disabled
October 22, 2025 17:54
Head branch was pushed to by a user without write access
Contributor
Author
|
@RyanCavanaugh I see you have approved before I pushed an extra change, you might want to take a quick look again. I think this might be slightly better in the context of the AST recovery~ |
Andarist
force-pushed
the
fix/crash-dec-on-await
branch
from
75315ee to
9735273
Compare
RyanCavanaugh
approved these changes
Oct 22, 2025
Copilot AI
added a commit
to microsoft/typescript-go
that referenced
this pull request
Feb 10, 2026
Port of microsoft/TypeScript#62659. In parseVariableDeclarationList, replace debug.Assert(isAwaitUsingDeclaration()) with a conditional check that breaks out of the switch if false, preventing a panic when encountering an invalid decorator on an await expression. Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62657