Reject using/await using declarations in switch case/default clauses#62731
Closed
PaulyBearCoding wants to merge 1 commit intomicrosoft:mainfrom
Closed
Reject using/await using declarations in switch case/default clauses#62731PaulyBearCoding wants to merge 1 commit intomicrosoft:mainfrom
PaulyBearCoding wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Fixes microsoft#62708 This change implements parser validation to reject `using` and `await using` declarations when directly nested within `case` or `default` clauses of switch statements, as per the updated ECMAScript spec. The spec was updated to disallow this pattern (see rbuckton/ecma262#14) because: - It makes the number of resource declarations statically knowable - All major JS engines agreed to this restriction - The pattern is rarely used in practice Changes: - Add new diagnostic (TS95198) for the error message - Add validation in parseVariableDeclarationList() to check parsingContext - Add error baseline for existing test case that now produces errors Valid workaround: Wrap using declarations in a block statement: case 0: { using x = ...; // OK } 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements parser validation to reject
usingandawait usingdeclarations when directly nested withincaseordefaultclauses of switch statements, per updated ECMAScript spec.Fixes #62708
Background
The ECMAScript spec was updated (rbuckton/ecma262#14) to disallow
usingdeclarations in switch case/default clauses. All major JS engines have agreed to implement this restriction.Rationale:
HasCallInTailPositionandHasUnterminatedUsingDeclaration)Related implementations:
usingdeclarations acornjs/acorn#1374Changes
1. Parser Validation
parseVariableDeclarationList()insrc/compiler/parser.tsparsingContext === ParsingContext.SwitchClauseStatementsusingandawait using2. Diagnostic Message
src/compiler/diagnosticMessages.jsonA '{0}' declaration cannot be placed within a 'case' or 'default' clause.3. Test Baseline
tests/cases/conformance/statements/VariableStatements/usingDeclarations/usingDeclarations.1.tsValid Workaround
Users can wrap
usingdeclarations in a block statement:Testing
usingin case clausesawait usingin case clausesusingin default clausesChecklist
🤖 Generated with Claude Code