Add failing test for reverse mapped this leak (#62779)#62801
Closed
priyankagnana wants to merge 2 commits intomicrosoft:mainfrom
Closed
Add failing test for reverse mapped this leak (#62779)#62801priyankagnana wants to merge 2 commits intomicrosoft:mainfrom
this leak (#62779)#62801priyankagnana wants to merge 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Member
|
We don't need a PR for the failing test alone. The issue already has it, so we should add this when the issue is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #62779
This PR adds a failing compiler test for issue #62779.
Summary
The test demonstrates that
thisinside a reverse-mapped type leaks a generic key type and causes incorrect inference (T[string]) instead of the concrete property return type.Files added
Reproduction
The test is the minimal reproduction from the issue and is runnable with the existing test harness.
Notes
npm test -- tests/cases/compiler/reverseMappedThisLeak.ts(should pass once baselines are inreference/)npm test -- --generateBaselinewas used earlier to create these baselines.(Please let me know if maintainers want a smaller repro or further variations.)