Update CopyrightNotice.txt (typo)#62808
Closed
justanotheranonymoususer wants to merge 1 commit intomicrosoft:mainfrom
Closed
Update CopyrightNotice.txt (typo)#62808justanotheranonymoususer wants to merge 1 commit intomicrosoft:mainfrom
justanotheranonymoususer wants to merge 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Author
Contributor
|
From the Pull Request template:
|
Author
|
What work? Just merge it
…On Wed, Nov 26, 2025, 20:19 Martin Johns ***@***.***> wrote:
*MartinJohns* left a comment (microsoft/TypeScript#62808)
<#62808 (comment)>
From the Pull Request template
<https://github.com/microsoft/TypeScript/blob/main/.github/pull_request_template.md?plain=1>
:
** Please don't send typo fixes! **
Please don't send a PR solely for the purpose of fixing a typo, unless that
typo truly hurts understanding of the text. Each PR represents work for the
maintainers, and that work should provide commensurate value.
—
Reply to this email directly, view it on GitHub
<#62808 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMDRPDQK3VZOYJKI7HCNO336XVKLAVCNFSM6AAAAACNJCT6F6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOBSGY3DGNBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
The work consists of reviewing the changes and making sure they're correct. The work consists of fixing the automated checks (which are currently failing due to your change). |
Author
|
If tests fail because of typo fix in txt file, something is wrong with the
tests
…On Thu, Nov 27, 2025 at 11:12 AM Martin Johns ***@***.***> wrote:
*MartinJohns* left a comment (microsoft/TypeScript#62808)
<#62808 (comment)>
The work consists of reviewing the changes and making sure they're
correct. The work consists of fixing the automated checks (which are
currently failing due to your change).
—
Reply to this email directly, view it on GitHub
<#62808 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMDRPFEIG2Z3BHGQSCTT6D362563AVCNFSM6AAAAACNJCT6F6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOBUHA2TQNZTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
If you're going to send a PR for a typo in defiance of the contributing guidelines, please at least send one that doesn't break the build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IANAL, but that's a typo