Improve satisfies semantics: return never when target type is never#62811
Closed
ViKing-Coder-jpg wants to merge 1 commit intomicrosoft:mainfrom
Closed
Improve satisfies semantics: return never when target type is never#62811ViKing-Coder-jpg wants to merge 1 commit intomicrosoft:mainfrom
ViKing-Coder-jpg wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
|
Won't this change allow |
Member
|
I don't understand the goal here and this isn't an approved change. In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Make
satisfiesNarrow toneverWhen Target Type IsneverIssue---> #62807 — "Switch doesn't narrow type when type isn't a discriminated union"
This PR updates the TypeScript compiler so that a
satisfiesexpression produces the typeneverwhen its target type is exactly the intrinsicnevertype. This allows patterns like:assertNever(foo satisfies never);