Improve error messages for discriminated union incompatible members#62837
Closed
alpha2420 wants to merge 5 commits intomicrosoft:mainfrom
Closed
Improve error messages for discriminated union incompatible members#62837alpha2420 wants to merge 5 commits intomicrosoft:mainfrom
alpha2420 wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Fixes microsoft#62737 When assigning objects with wider discriminator unions to discriminated union types, TypeScript now identifies the actual incompatible types from the source union, rather than showing a misleading error about a compatible type. Before: Type '"foo"' is not assignable to type '"bar"' After: The type(s) '"baz"' are not present in the discriminator 'discriminator' of the target. This change: - Adds detection for discriminated union assignment errors - Reports which specific types from the source are missing in the target - Includes the discriminator property name in the error message - Adds comprehensive test cases
Collaborator
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62737
When assigning objects with wider discriminator unions to discriminated union types, TypeScript now identifies the actual incompatible types from the source union, rather than showing a misleading error about a compatible type.
Before:
Type '"foo"' is not assignable to type '"bar"'After:
The type(s) '"baz"' are not present in the discriminator 'discriminator' of the target.This change: