Skip to content

Enhance isJS check in getNewImportFixes function#62840

Closed
johnsoncodehk wants to merge 2 commits intomicrosoft:mainfrom
johnsoncodehk:patch-3
Closed

Enhance isJS check in getNewImportFixes function#62840
johnsoncodehk wants to merge 2 commits intomicrosoft:mainfrom
johnsoncodehk:patch-3

Conversation

@johnsoncodehk
Copy link
Copy Markdown

Fixes vuejs/language-tools#4582

In getNewImportFixes, prioritize checking scriptKind over file extension for isJs. This ensures consistent JsdocTypeImport behavior for file types added via LS plugins.

Copilot AI review requested due to automatic review settings December 4, 2025 20:33
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Dec 4, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 4, 2025
@typescript-bot
Copy link
Copy Markdown
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 4, 2025
@typescript-bot
Copy link
Copy Markdown
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the isJS check in the getNewImportFixes function to better support Language Service plugins (like Vue.js language tools) that add custom file types via LS plugins. The change prioritizes checking scriptKind over file extension to determine if a file should be treated as JavaScript, ensuring consistent JsdocTypeImport behavior.

Key changes:

  • Import ScriptKind enum for script kind checking
  • Remove the top-level isJs variable that only checked file extension
  • Move JS determination logic into the conditional block where it's needed, checking scriptKind first with hasJSFileExtension as fallback

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tyreektyreek7
Copy link
Copy Markdown

Pay as u use

Copy link
Copy Markdown

@tyreektyreek7 tyreektyreek7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Auto-import in JSDoc always uses ts behaviour

5 participants