Fixed issues in relater related to tuples with variadic elements by Andarist · Pull Request #62983 · microsoft/TypeScript

Andarist · 2026-01-13T18:02:22Z

RyanCavanaugh · 2026-01-14T18:13:14Z

typescript-bot · 2026-01-14T18:13:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2026-01-14T18:35:53Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2026-01-14T18:42:52Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/62983/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"
1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2026-01-14T19:16:52Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,387	_50,387	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,092k (± 0.75%)}	_{193,745k (± 0.98%)}	_~	_192,447k	_196,280k	_{p=0.297 n=6}
_{Parse Time}	_{1.30s (± 0.97%)}	_{1.29s (± 0.65%)}	_~	_1.29s	_1.31s	_{p=0.445 n=6}
_{Bind Time}	_0.76s	_0.76s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.87s (± 0.39%)}	_{9.87s (± 0.31%)}	_~	_9.83s	_9.92s	_{p=0.871 n=6}
_{Emit Time}	_{2.75s (± 0.38%)}	_{2.73s (± 0.44%)}	_~	_2.72s	_2.75s	_{p=0.084 n=6}
_{Total Time}	_{14.68s (± 0.22%)}	_{14.66s (± 0.28%)}	_~	_14.62s	_14.73s	_{p=0.195 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_955,823	_955,823	_~	_~	_~	_{p=1.000 n=6}
_Types	_415,853	_415,853	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,253,937k (± 0.00%)}	_{1,253,911k (± 0.00%)}	_~	_1,253,847k	_1,254,014k	_{p=0.378 n=6}
_{Parse Time}	_{6.52s (± 0.64%)}	_{6.56s (± 0.61%)}	_~	_6.51s	_6.62s	_{p=0.258 n=6}
_{Bind Time}	_{1.96s (± 0.43%)}	_{1.96s (± 0.38%)}	_~	_1.95s	_1.97s	_{p=0.652 n=6}
_{Check Time}	_{32.38s (± 0.33%)}	_{32.47s (± 0.30%)}	_~	_32.34s	_32.60s	_{p=0.127 n=6}
_{Emit Time}	_{14.98s (± 0.32%)}	_{14.99s (± 0.34%)}	_~	_14.94s	_15.08s	_{p=0.688 n=6}
_{Total Time}	_{55.84s (± 0.23%)}	_{55.97s (± 0.27%)}	_~	_55.75s	_56.14s	_{p=0.172 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,699,181	_2,699,181	_~	_~	_~	_{p=1.000 n=6}
_Types	_937,307	_937,307	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,028,637k (± 0.00%)}	_{3,028,579k (± 0.00%)}	_~	_3,028,498k	_3,028,644k	_{p=0.230 n=6}
_{Parse Time}	_{8.63s (± 0.46%)}	_{8.62s (± 0.19%)}	_~	_8.60s	_8.64s	_{p=1.000 n=6}
_{Bind Time}	_2.29s	_{2.29s (± 0.33%)}	_~	_2.28s	_2.30s	_{p=0.598 n=6}
_{Check Time}	_{93.78s (± 0.25%)}	_{93.87s (± 0.28%)}	_~	_93.59s	_94.31s	_{p=0.748 n=6}
_{Emit Time}	_0.31s	_0.31s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{105.00s (± 0.22%)}	_{105.09s (± 0.24%)}	_~	_104.79s	_105.51s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,252,015	_1,252,016	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,850	_259,850	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,508,410k (±11.84%)}	_{2,508,625k (±11.88%)}	_~	_2,386,640k	_3,117,446k	_{p=0.575 n=6}
_{Parse Time}	_{5.18s (± 0.88%)}	_{5.19s (± 0.94%)}	_~	_5.15s	_5.28s	_{p=0.872 n=6}
_{Bind Time}	_{1.86s (± 1.30%)}	_{1.86s (± 1.62%)}	_~	_1.81s	_1.90s	_{p=0.806 n=6}
_{Check Time}	_{35.56s (± 0.50%)}	_{35.57s (± 0.47%)}	_~	_35.40s	_35.87s	_{p=0.575 n=6}
_{Emit Time}	_{3.00s (± 1.54%)}	_{3.03s (± 2.15%)}	_~	_2.92s	_3.12s	_{p=0.471 n=6}
_{Total Time}	_{45.63s (± 0.44%)}	_{45.64s (± 0.27%)}	_~	_45.48s	_45.86s	_{p=0.873 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,252,015	_1,252,016	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,850	_259,850	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,061,178k (± 9.65%)}	_{3,182,505k (± 0.02%)}	_~	_3,181,652k	_3,183,419k	_{p=0.173 n=6}
_{Parse Time}	_{8.36s (± 1.55%)}	_{8.44s (± 0.60%)}	_~	_8.37s	_8.50s	_{p=0.295 n=6}
_{Bind Time}	_{2.79s (± 1.60%)}	_{2.76s (± 0.93%)}	_~	_2.72s	_2.79s	_{p=0.297 n=6}
_{Check Time}	_{53.18s (± 0.36%)}	_{53.32s (± 0.14%)}	_~	_53.23s	_53.39s	_{p=0.066 n=6}
_{Emit Time}	_{4.33s (± 2.14%)}	_{4.35s (± 1.94%)}	_~	_4.20s	_4.44s	_{p=0.810 n=6}
_{Total Time}	_{68.66s (± 0.46%)}	_{68.89s (± 0.19%)}	_~	_68.67s	_69.08s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_264,672	_264,673	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,063	_104,063	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{442,995k (± 0.02%)}	_{443,063k (± 0.02%)}	_~	_442,856k	_443,137k	_{p=0.230 n=6}
_{Parse Time}	_{3.53s (± 0.91%)}	_{3.52s (± 0.68%)}	_~	_3.48s	_3.54s	_{p=0.368 n=6}
_{Bind Time}	_{1.38s (± 0.99%)}	_{1.39s (± 0.59%)}	_~	_1.38s	_1.40s	_{p=0.868 n=6}
_{Check Time}	_{19.22s (± 0.20%)}	_{19.19s (± 0.25%)}	_~	_19.13s	_19.27s	_{p=0.286 n=6}
_{Emit Time}	_{1.54s (± 0.86%)}	_{1.54s (± 1.46%)}	_~	_1.52s	_1.58s	_{p=1.000 n=6}
_{Total Time}	_{25.68s (± 0.26%)}	_{25.64s (± 0.31%)}	_~	_25.57s	_25.78s	_{p=0.335 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₃	₇₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,493	_225,493	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,373	_94,373	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,831k (± 0.02%)}	_{369,869k (± 0.05%)}	_~	_369,770k	_370,220k	_{p=0.936 n=6}
_{Parse Time}	_{3.55s (± 1.03%)}	_{3.52s (± 0.71%)}	_~	_3.48s	_3.55s	_{p=0.172 n=6}
_{Bind Time}	_{2.04s (± 0.96%)}	_{2.04s (± 1.57%)}	_~	_2.01s	_2.09s	_{p=0.935 n=6}
_{Check Time}	_{20.62s (± 0.45%)}	_{20.72s (± 0.45%)}	_~	_20.59s	_20.83s	_{p=0.149 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{26.22s (± 0.44%)}	_{26.28s (± 0.42%)}	_~	_26.15s	_26.42s	_{p=0.423 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_4,107,898	_4,107,898	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,299,167	_1,299,167	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,901,470k (± 0.00%)}	_{3,901,411k (± 0.00%)}	_~	_3,901,345k	_3,901,486k	_{p=0.810 n=6}
_{Parse Time}	_{19.53s (± 1.28%)}	_{19.62s (± 0.50%)}	_~	_19.46s	_19.72s	_{p=0.810 n=6}
_{Bind Time}	_{6.98s (±13.07%)}	_{6.57s (± 0.64%)}	_~	_6.50s	_6.62s	_{p=0.873 n=6}
_{Check Time}	_{136.96s (± 3.47%)}	_{138.07s (± 2.02%)}	_~	_135.69s	_142.18s	_{p=0.471 n=6}
_{Emit Time}	_{54.91s (±13.60%)}	_{50.58s (±15.91%)}	_~	_46.93s	_67.02s	_{p=0.128 n=6}
_{Total Time}	_{218.38s (± 4.81%)}	_{214.85s (± 4.52%)}	_~	_208.97s	_233.84s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_384,170	_384,170	_~	_~	_~	_{p=1.000 n=6}
_Types	_168,308	_168,308	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{543,305k (± 0.03%)}	_{543,462k (± 0.04%)}	_~	_543,179k	_543,660k	_{p=0.128 n=6}
_{Parse Time}	_{4.70s (± 0.35%)}	_{4.71s (± 0.42%)}	_~	_4.69s	_4.74s	_{p=0.139 n=6}
_{Bind Time}	_{2.02s (± 1.02%)}	_{2.00s (± 0.80%)}	_~	_1.98s	_2.02s	_{p=0.052 n=6}
_{Check Time}	_{23.81s (± 1.50%)}	_{23.54s (± 1.04%)}	_~	_23.35s	_24.02s	_{p=0.336 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.53s (± 1.22%)}	_{30.25s (± 0.86%)}	_~	_30.09s	_30.77s	_{p=0.575 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_696,322	_696,322	_~	_~	_~	_{p=1.000 n=6}
_Types	_212,496	_212,496	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{590,963k (± 0.02%)}	_{591,151k (± 0.02%)}	_{+188k (+ 0.03%)}	_590,931k	_591,259k	_{p=0.045 n=6}
_{Parse Time}	_{4.14s (± 0.37%)}	_{4.15s (± 0.74%)}	_~	_4.12s	_4.20s	_{p=0.805 n=6}
_{Bind Time}	_{1.41s (± 1.47%)}	_{1.40s (± 1.17%)}	_~	_1.38s	_1.42s	_{p=0.511 n=6}
_{Check Time}	_{21.52s (± 1.56%)}	_{21.07s (± 1.55%)}	_~	_20.82s	_21.71s	_{p=0.054 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{27.07s (± 1.28%)}	_{26.62s (± 1.19%)}	_~	_26.33s	_27.22s	_{p=0.077 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2026-01-14T19:42:46Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62983/merge:

Everything looks good!

typescript-bot · 2026-03-24T21:23:22Z

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Fixed issues in relater related to tuples with variadic elements

4499503

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 13, 2026

Andarist added 4 commits January 13, 2026 21:13

extra tweak

4c6c8df

fix confusing error

63a090d

add test

e9ef752

Merge remote-tracking branch 'origin/main' into fix/tuple-matching-crash

b5b9f82

Andarist marked this pull request as ready for review January 14, 2026 09:51

typescript-bot closed this Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed issues in relater related to tuples with variadic elements#62983

Fixed issues in relater related to tuples with variadic elements#62983
Andarist wants to merge 5 commits intomicrosoft:mainfrom
Andarist:fix/tuple-matching-crash

Andarist commented Jan 13, 2026

Uh oh!

RyanCavanaugh commented Jan 14, 2026

Uh oh!

typescript-bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

typescript-bot commented Jan 14, 2026

Uh oh!

typescript-bot commented Jan 14, 2026

Uh oh!

typescript-bot commented Jan 14, 2026

tsc

Uh oh!

typescript-bot commented Jan 14, 2026

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Andarist commented Jan 13, 2026

Uh oh!

RyanCavanaugh commented Jan 14, 2026

Uh oh!

typescript-bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 14, 2026

Uh oh!

typescript-bot commented Jan 14, 2026

Uh oh!

typescript-bot commented Jan 14, 2026

tsc

Uh oh!

typescript-bot commented Jan 14, 2026

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Jan 14, 2026 •

edited

Loading