Fix incorrectly reported 2689 error#63072
Conversation
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
| case SyntaxKind.ExpressionWithTypeArguments: | ||
| if (isEntityNameExpression((node as ExpressionWithTypeArguments).expression)) { | ||
| return (node as ExpressionWithTypeArguments).expression as EntityNameExpression; | ||
| if (isExpressionWithTypeArgumentsInClassExtendsClause(node) && isEntityNameExpression(node.expression)) { |
There was a problem hiding this comment.
This func does some goofy stuff with JSDoc, but maybe that's fine
There was a problem hiding this comment.
Weird, Corsa doesn't have this func at all. Wonder why its callers are gone
There was a problem hiding this comment.
This func does some goofy stuff with JSDoc, but maybe that's fine
Yeah, I've seen that but assumed it's fine and won't hurt this.
Weird, Corsa doesn't have this func at all. Wonder why its callers are gone
I'll take a look at Corsa's implementation later but FWIW, it suffers from the same issue: TS GO playground
There was a problem hiding this comment.
Oh, it totally does, I just went to search for this func name and was surprised to see it not existing!
There was a problem hiding this comment.
Weird, Corsa doesn't have this func at all. Wonder why its callers are gone
It has c.getEntityNameForExtendingInterface, c.checkAndReportErrorForExtendingInterface, ast.IsEntityNameExpression and ast.IsExpressionWithTypeArgumentsInClassExtendsClause. Maybe you have missed one of those? I don't know which one you referred to as missing.
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
spotted by @LukeAbby
current confusing error: