Skip to content

Port tsgo PR 3276 for testing#63316

Closed
jakebailey wants to merge 1 commit intomicrosoft:mainfrom
jakebailey:port-tsgo-3276
Closed

Port tsgo PR 3276 for testing#63316
jakebailey wants to merge 1 commit intomicrosoft:mainfrom
jakebailey:port-tsgo-3276

Conversation

@jakebailey
Copy link
Copy Markdown
Member

Just seeing what microsoft/typescript-go#3288 does to extended tests

@jakebailey
Copy link
Copy Markdown
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 29, 2026

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Copy Markdown
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Copy Markdown
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/63316/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Copy Markdown
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 82,521 82,521 ~ ~ ~ p=1.000 n=6
Types 125,280 125,280 ~ ~ ~ p=1.000 n=6
Memory used 275,565k (± 0.66%) 276,153k (± 0.68%) ~ 274,410k 277,915k p=0.230 n=6
Parse Time 1.29s (± 0.42%) 1.31s (± 0.64%) ~ 1.29s 1.31s p=0.052 n=6
Bind Time 0.75s (± 0.84%) 0.75s (± 0.54%) ~ 0.75s 0.76s p=0.673 n=6
Check Time 14.15s (± 1.41%) 14.21s (± 0.94%) ~ 14.05s 14.42s p=0.295 n=6
Emit Time 2.67s (± 0.31%) 2.66s (± 0.73%) ~ 2.64s 2.69s p=0.739 n=6
Total Time 18.87s (± 1.08%) 18.93s (± 0.77%) ~ 18.75s 19.15s p=0.378 n=6
angular-1 - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 959,140 959,140 ~ ~ ~ p=1.000 n=6
Types 416,033 416,033 ~ ~ ~ p=1.000 n=6
Memory used 1,260,867k (± 0.00%) 1,260,881k (± 0.00%) ~ 1,260,828k 1,260,928k p=0.575 n=6
Parse Time 6.57s (± 0.51%) 6.58s (± 0.26%) ~ 6.56s 6.60s p=0.685 n=6
Bind Time 2.01s (± 0.41%) 2.02s (± 0.26%) ~ 2.01s 2.02s p=0.923 n=6
Check Time 32.59s (± 0.31%) 32.58s (± 0.29%) ~ 32.43s 32.69s p=0.873 n=6
Emit Time 15.26s (± 0.24%) 15.24s (± 0.44%) ~ 15.13s 15.34s p=0.422 n=6
Total Time 56.45s (± 0.23%) 56.41s (± 0.27%) ~ 56.16s 56.58s p=0.748 n=6
mui-docs - node (v18.15.0, x64)
Errors 11,136 11,136 ~ ~ ~ p=1.000 n=6
Symbols 2,202,148 2,202,148 ~ ~ ~ p=1.000 n=6
Types 764,674 764,674 ~ ~ ~ p=1.000 n=6
Memory used 2,642,427k (± 0.00%) 2,642,459k (± 0.00%) ~ 2,642,357k 2,642,507k p=0.936 n=6
Parse Time 7.82s (± 2.12%) 7.85s (± 0.13%) ~ 7.84s 7.87s p=0.076 n=6
Bind Time 2.10s (± 9.86%) 2.03s (± 0.25%) ~ 2.02s 2.03s p=0.352 n=6
Check Time 71.69s (± 0.35%) 71.48s (± 0.32%) ~ 71.13s 71.80s p=0.173 n=6
Emit Time 0.30s (± 2.75%) 0.29s (± 2.83%) ~ 0.29s 0.31s p=0.718 n=6
Total Time 81.90s (± 0.29%) 81.65s (± 0.28%) ~ 81.30s 81.97s p=0.108 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,363 1,227,364 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 267,197 267,197 ~ ~ ~ p=1.000 n=6
Memory used 2,474,162k (± 7.62%) 2,534,974k (±12.01%) ~ 2,352,578k 3,081,324k p=0.298 n=6
Parse Time 5.20s (± 0.97%) 5.20s (± 0.86%) ~ 5.14s 5.26s p=1.000 n=6
Bind Time 1.85s (± 1.26%) 1.85s (± 2.02%) ~ 1.80s 1.89s p=0.936 n=6
Check Time 35.75s (± 0.61%) 35.91s (± 1.02%) ~ 35.33s 36.36s p=0.575 n=6
Emit Time 3.06s (± 4.52%) 3.04s (± 1.39%) ~ 2.98s 3.10s p=0.687 n=6
Total Time 45.87s (± 0.59%) 46.00s (± 0.85%) ~ 45.41s 46.52s p=0.378 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,363 1,227,364 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 267,197 267,197 ~ ~ ~ p=1.000 n=6
Memory used 2,845,847k (± 5.20%) 2,811,160k (± 6.59%) ~ 2,575,156k 3,148,545k p=1.000 n=6
Parse Time 6.75s (± 1.32%) 6.74s (± 0.79%) ~ 6.69s 6.81s p=1.000 n=6
Bind Time 2.25s (± 1.03%) 2.28s (± 1.71%) ~ 2.23s 2.33s p=0.261 n=6
Check Time 42.80s (± 1.03%) 43.02s (± 0.97%) ~ 42.60s 43.76s p=0.298 n=6
Emit Time 3.53s (± 1.63%) 3.54s (± 3.56%) ~ 3.42s 3.74s p=1.000 n=6
Total Time 55.34s (± 0.96%) 55.61s (± 0.82%) ~ 55.19s 56.36s p=0.128 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 261,660 261,661 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,322 104,322 ~ ~ ~ p=1.000 n=6
Memory used 439,372k (± 0.01%) 439,410k (± 0.01%) ~ 439,368k 439,438k p=0.093 n=6
Parse Time 4.40s (± 1.01%) 4.38s (± 0.66%) ~ 4.34s 4.42s p=0.375 n=6
Bind Time 1.67s (± 0.63%) 1.70s (± 1.01%) +0.03s (+ 1.59%) 1.67s 1.72s p=0.029 n=6
Check Time 23.93s (± 0.42%) 23.91s (± 0.27%) ~ 23.85s 24.00s p=0.936 n=6
Emit Time 1.94s (± 1.49%) 1.93s (± 0.54%) ~ 1.92s 1.95s p=0.684 n=6
Total Time 31.94s (± 0.44%) 31.92s (± 0.12%) ~ 31.88s 31.97s p=1.000 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 271 271 ~ ~ ~ p=1.000 n=6
Symbols 225,897 225,897 ~ ~ ~ p=1.000 n=6
Types 93,564 93,564 ~ ~ ~ p=1.000 n=6
Memory used 371,632k (± 0.01%) 371,626k (± 0.02%) ~ 371,541k 371,713k p=0.810 n=6
Parse Time 2.86s (± 1.08%) 2.83s (± 1.19%) ~ 2.78s 2.86s p=0.334 n=6
Bind Time 1.64s (± 1.27%) 1.63s (± 1.08%) ~ 1.61s 1.66s p=0.441 n=6
Check Time 17.47s (± 0.69%) 17.46s (± 0.42%) ~ 17.34s 17.52s p=0.936 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.97s (± 0.42%) 21.92s (± 0.43%) ~ 21.80s 22.01s p=0.518 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=NaN n=0
Symbols 0 0 ~ ~ ~ p=NaN n=0
Types 0 0 ~ ~ ~ p=NaN n=0
Memory used 0k 0k ~ ~ ~ p=NaN n=0
Parse Time 0s 0s ~ ~ ~ p=NaN n=0
Bind Time 0s 0s ~ ~ ~ p=NaN n=0
Check Time 0s 0s ~ ~ ~ p=NaN n=0
Emit Time 0s 0s ~ ~ ~ p=NaN n=0
Total Time 0s 0s ~ ~ ~ p=NaN n=0
webpack - node (v18.15.0, x64)
Errors 8 8 ~ ~ ~ p=1.000 n=6
Symbols 408,835 408,835 ~ ~ ~ p=1.000 n=6
Types 186,908 186,908 ~ ~ ~ p=1.000 n=6
Memory used 570,964k (± 0.02%) 570,960k (± 0.03%) ~ 570,783k 571,201k p=0.810 n=6
Parse Time 4.74s (± 0.34%) 4.73s (± 0.58%) ~ 4.70s 4.77s p=0.251 n=6
Bind Time 2.03s (± 1.06%) 2.04s (± 1.29%) ~ 1.99s 2.06s p=0.627 n=6
Check Time 24.54s (± 0.37%) 24.46s (± 0.52%) ~ 24.32s 24.61s p=0.230 n=6
Emit Time 0.01s (±48.94%) 0.00s (±154.76%) ~ 0.00s 0.01s p=0.112 n=6
Total Time 31.32s (± 0.27%) 31.22s (± 0.48%) ~ 31.05s 31.40s p=0.173 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 782,787 782,787 ~ ~ ~ p=1.000 n=6
Types 228,290 228,290 ~ ~ ~ p=1.000 n=6
Memory used 698,173k (± 0.01%) 698,176k (± 0.01%) ~ 698,125k 698,296k p=0.688 n=6
Parse Time 4.93s (± 0.42%) 4.93s (± 0.75%) ~ 4.89s 4.99s p=0.805 n=6
Bind Time 1.58s (± 1.01%) 1.58s (± 0.93%) ~ 1.57s 1.60s p=1.000 n=6
Check Time 23.07s (± 0.31%) 23.25s (± 1.13%) ~ 23.10s 23.78s p=0.054 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 29.58s (± 0.25%) 29.77s (± 0.84%) +0.18s (+ 0.62%) 29.62s 30.27s p=0.043 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Copy Markdown
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/63316/merge:

Everything looks good!

@jakebailey jakebailey closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants