Python: fix: MCP reconnection when the mcp server is rebooted. The mcp sessio…#5206
Open
bskhural wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: fix: MCP reconnection when the mcp server is rebooted. The mcp sessio…#5206bskhural wants to merge 1 commit intomicrosoft:mainfrom
bskhural wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…n throws the 'McpError: Session Terminated' hence ClosedResourceError section is skipped.
|
@bskhural please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Member
eavanvalkenburg
left a comment
There was a problem hiding this comment.
these changes make sense, but I would like to see some tests checking all these paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n throws the 'McpError: Session Terminated' hence ClosedResourceError section is skipped.
Motivation and Context
The Agent cannot establish the mcp reconnection when the mcp server is restarted.
Description
Agent's MCP session is currently refreshed when there is "ClosedResourceError" exception received. However, the mcp client thrown "McpError: Session Terminated", which is why the "ClosedResourceError" exception block is not invoked. The changes would check both McpError and ClosedResourceError exceptions and refresh the mcp session from agent.
Contribution Checklist