Skip to content

.NET: Disable flaky timing-dependent integration tests #5207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergeyMenshykh wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Open

.NET: Disable flaky timing-dependent integration tests #5207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dotnet/tests/Microsoft.Agents.AI.DurableTask.IntegrationTests/ConsoleAppSamplesValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ protected override void ConfigureAdditionalEnvironmentVariables(ProcessStartInfo
setEnvVar("REDIS_CONNECTION_STRING", $"localhost:{RedisPort}");
}

[Fact]
[Fact(Skip = SkipFlakyTimingTest)]
public async Task SingleAgentSampleValidationAsync()
{
using CancellationTokenSource testTimeoutCts = this.CreateTestTimeoutCts();
Expand Down Expand Up @@ -69,7 +69,7 @@ await this.RunSampleTestAsync(samplePath, async (process, logs) =>
});
}

[Fact]
[Fact(Skip = SkipFlakyTimingTest)]
public async Task SingleAgentOrchestrationChainingSampleValidationAsync()
{
using CancellationTokenSource testTimeoutCts = this.CreateTestTimeoutCts();
Expand Down Expand Up @@ -105,7 +105,7 @@ await this.RunSampleTestAsync(samplePath, async (process, logs) =>
});
}

[Fact]
[Fact(Skip = SkipFlakyTimingTest)]
public async Task MultiAgentConcurrencySampleValidationAsync()
{
using CancellationTokenSource testTimeoutCts = this.CreateTestTimeoutCts();
Expand Down Expand Up @@ -160,7 +160,7 @@ await this.RunSampleTestAsync(samplePath, async (process, logs) =>
});
}

[Fact]
[Fact(Skip = SkipFlakyTimingTest)]
public async Task MultiAgentConditionalSampleValidationAsync()
{
using CancellationTokenSource testTimeoutCts = this.CreateTestTimeoutCts();
Expand Down
4 changes: 3 additions & 1 deletion ...s/Microsoft.Agents.AI.DurableTask.IntegrationTests/WorkflowConsoleAppSamplesValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ namespace Microsoft.Agents.AI.DurableTask.IntegrationTests;
[Trait("Category", "SampleValidation")]
public sealed class WorkflowConsoleAppSamplesValidation(ITestOutputHelper outputHelper) : SamplesValidationBase(outputHelper)
{
private const string SkipFlakyTimingTest = "Flaky: timing-dependent LLM test, see https://github.com/microsoft/agent-framework/issues/4971";

// In CI, `dotnet run` builds samples from scratch and LLM calls add latency, so 60s is not enough.
private static readonly TimeSpan s_testTimeout = TimeSpan.FromSeconds(180);

Expand Down Expand Up @@ -505,7 +507,7 @@ await this.RunSampleTestAsync(samplePath, (process, logs) =>
});
}

[Fact]
[Fact(Skip = SkipFlakyTimingTest)]
public async Task WorkflowAndAgentsSampleValidationAsync()
{
using CancellationTokenSource testTimeoutCts = this.CreateTestTimeoutCts(s_testTimeout);
Expand Down
Loading