feat: in verbose mode have mock print all output#231
Open
dmcilvaney wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the mock runner to make verbose mode stream much more of mock’s output directly to the console, and adjusts the long-running UX so progress spinners don’t interfere with live output.
Changes:
- Add
--verboseto mock invocations whenctx.Verbose()is enabled (and keep--quietfor non-verbose runs). - Skip the indeterminate “Waiting for mock…” spinner during RPM builds when running in verbose mode.
Comment on lines
+651
to
656
| if r.verbose { | ||
| // Have mock stream its full build output (including build.log) live to the console. | ||
| args = append(args, "--verbose") | ||
| } else { | ||
| args = append(args, "--quiet") | ||
| } |
Comment on lines
+651
to
656
| if r.verbose { | ||
| // Have mock stream its full build output (including build.log) live to the console. | ||
| args = append(args, "--verbose") | ||
| } else { | ||
| args = append(args, "--quiet") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is VERY verbose, but it is very useful for tracking progress in pipelines etc.