Skip to content

Conversation

@rishabhmalikMS
Copy link
Contributor

@rishabhmalikMS rishabhmalikMS commented Dec 19, 2025

Context

This PR completes the integration of node version selection strategy with container operation provider. It also covers custom node strategy support.

Related Work Items:

  • Container node version strategy implementation AB#2343104
  • Custom Node Strategy + Test for custom node AB#2343431

Description

Key Changes:

  1. Custom Node Strategy Integration: Full integration of CustomNodeStrategy with highest priority for detecting user-specified node paths in both host and container environments
  2. Container Integration with Strategy Execution: Container operations now execute node version strategy BEFORE container startup to ensure proper EOL policy enforcement
  3. L0 unit tests for custom node input - Update test scenarios with custom node scenarios

Architecture Key Points:

  • Strategy Priority: Custom node strategy takes precedence over all other selection mechanisms
  • Clean Separation: Container operations focus on infrastructure, orchestrator handles policy and selection
  • Exception Flow: EOL policy violations properly flows up through strategy layer

Risk Assessment (Low / Medium / High)

Risk Level: Medium
Justification:

  • Changes affect critical container startup and node selection paths
  • Maintains existing container knob behavior and legacy fallback mechanisms
  • Changes are behind UseNodeVersionStrategy knob for controlled rollout

Unit Tests Added or Updated (Yes / No)

  • Tests added for custom node scenarios

Additional Testing Performed

List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).


Change Behind Feature Flag (Yes / No)

Yes, changes are behind feature flag


Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.

Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).

Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

@rishabhmalikMS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rishabhmalikMS rishabhmalikMS marked this pull request as ready for review December 19, 2025 06:59
@rishabhmalikMS rishabhmalikMS requested review from a team as code owners December 19, 2025 06:59
@rishabhmalikMS rishabhmalikMS changed the title Users/rishabhmalik ms/container integration Container Provider integration with Node version strategies Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants