-
Notifications
You must be signed in to change notification settings - Fork 648
test(container): assert OCI Config.User is unset in static-image checks #17621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christopherco
wants to merge
1
commit into
4.0
Choose a base branch
from
chrco/static-image-no-config-user
base: 4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-License-Identifier: MIT | ||
| """OCI image-config validation (container images). | ||
|
|
||
| Shared test (not under a ``cases/<family>/`` directory) so it applies to | ||
| every container image family — both ``core`` (container-base) and the | ||
| ``distroless-*`` variants. Gated on the ``container`` capability via | ||
| ``@pytest.mark.require_capability`` so it only runs for container images | ||
| (VM images, which declare ``container = false``, are skipped). | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| @pytest.mark.require_capability("container") | ||
| def test_no_explicit_config_user(oci_image_config: dict[str, object]) -> None: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should use a marker, e.g.:
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added the container capability |
||
| """OCI ``Config.User`` must be unset. | ||
|
|
||
| Azure Linux base/distroless images intentionally leave ``Config.User`` | ||
| unset (matching AZL 3.0 and mainstream base images such as Debian, | ||
| Ubuntu, Alpine, UBI, Fedora). The OCI runtime default for an unset | ||
| user is uid 0, so this does not change effective runtime behavior, but | ||
| explicitly declaring a user diverges from that convention. An explicit | ||
| empty string still counts as "set" and must therefore also fail. | ||
| """ | ||
| config = oci_image_config.get("config") | ||
| assert isinstance(config, dict), ( | ||
| f"OCI image config has no 'config' object (got {type(config).__name__}); " | ||
| f"cannot validate Config.User. Full inspect output: {oci_image_config!r}" | ||
| ) | ||
| assert "User" not in config, ( | ||
| "OCI Config.User must be unset, but the image explicitly declares " | ||
| f"User={config['User']!r}. Remove the user attribute from the kiwi " | ||
| "<containerconfig> so the published manifest leaves Config.User unset." | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the metadata updates here; their omission on the distroless containers was an oversight.