feat(react-components): migrate useArrowNavigationGroup to focusgroup where possible#35941
Draft
smhigley wants to merge 3 commits intomicrosoft:masterfrom
Draft
feat(react-components): migrate useArrowNavigationGroup to focusgroup where possible#35941smhigley wants to merge 3 commits intomicrosoft:masterfrom
smhigley wants to merge 3 commits intomicrosoft:masterfrom
Conversation
spmonahan
reviewed
Apr 2, 2026
| type: 'button', | ||
| 'aria-selected': `${!!isSelected}`, | ||
| ...defaultTabProps, | ||
| focusGroupStart: isSelected, |
Contributor
There was a problem hiding this comment.
Suggested change
| focusGroupStart: isSelected, | |
| focusgroupstart: isSelected, |
Maybe?
Contributor
Author
There was a problem hiding this comment.
Turns out the issue was that it needed a string value, it wasn't getting applied as a boolean attribute. I need to dig in a little more on why, but I've pushed an update setting them as strings for now so folks can at least test it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT/EXPERIMENTAL PR, DO NOT MERGE
This updates supported usage of
useArrowNavigationGroupfromreact-tabsterto the new focusgroup attribute.Note: React does not currently support setting
focusgroupstartin JSX/TSX, though I added the prop in anyway as a POC.TODO: add polyfill once it's published (https://github.com/microsoft/polyfills/blob/main/packages/focusgroup/src/polyfill.js)
There are some exceptions that cannot currently be migrated to
focusgroup:gridorgrid-linear, since grid is not yet supported byfocusgrouptabbable, sincefocusgroupdoes not support dual arrowing + tabbing behavior (this also doesn't really have precedent in established keyboard patterns). Right now, the only use is in Nav, and the soon-to-be-deprecated Accordion behavior that allows arrowingfocusgroup: nonewrapping inner CarouselCard content without adding an extra<div>