feat(react-dialog): [CAP] closeButton prop to DialogTitle#35956
Draft
GianoglioEnrico wants to merge 1 commit intomicrosoft:masterfrom
Draft
feat(react-dialog): [CAP] closeButton prop to DialogTitle#35956GianoglioEnrico wants to merge 1 commit intomicrosoft:masterfrom
closeButton prop to DialogTitle#35956GianoglioEnrico wants to merge 1 commit intomicrosoft:masterfrom
Conversation
…icon from Dismiss20Regular to Dismiss16Regular
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -6,6 +6,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Dialog 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Dialog.title custom action - Dark Mode.chromium.png | 98 | Changed |
| vr-tests-react-components/Dialog.title custom action - High Contrast.chromium.png | 145 | Changed |
| vr-tests-react-components/Dialog.non-modal - High Contrast.chromium.png | 53 | Changed |
| vr-tests-react-components/Dialog.title custom action.chromium.png | 107 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 515 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 731 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 103 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 116 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 37 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled.chromium.png | 677 | Changed |
There were 7 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the raw
<button>element in DialogTitle's default non-modal close action with theButtoncomponent from@fluentui/react-button. It also replace theDismiss20RegularwithDismiss16Regularicon.Changes
closeButtonprop: AddedcloseButton?: ButtonPropstoDialogTitleProps, allowing consumers to customize the default close button (e.g.aria-label,appearance,size) without replacing the entireactionslot.<Button appearance="transparent" size="small" icon={<Dismiss16Regular />} />instead of a raw<button>with internal styles.useDialogTitleInternalStyles: No longer needed since theButtoncomponent provides its own styling.marginRight: '-8px'to the action slot to keep the dismiss icon visually aligned with the right edge of the dialog body.Notes
The
closeButtonprop is only applied to the default close button and has no effect when action is explicitly provided.