Skip to content

fix(charts): modify isSafeUrl utility #35963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mainframev merged 2 commits into from
Apr 9, 2026
Merged

fix(charts): modify isSafeUrl utility #35963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa89d8d
fix(charts): modify isSafeUrl utility
mainframev Apr 8, 2026
7773843
chore: change files
mainframev Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-f3b97d35-d40a-4e05-ab50-3a1d6d34a0ce.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: isSafeUrl utility",
"packageName": "@fluentui/react-charting",
"email": "vgenaev@gmail.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-charts-81c5619a-02e7-4074-9355-e7565f999790.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: isSafeUrl utility",
"packageName": "@fluentui/react-charts",
"email": "vgenaev@gmail.com",
"dependentChangeType": "patch"
}
12 changes: 10 additions & 2 deletions packages/charts/react-charting/src/utilities/UtilityUnitTests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1564,8 +1564,16 @@ describe('isSafeUrl', () => {
expect(utils.isSafeUrl('file:///etc/passwd')).toBe(false);
});

test('Should block ftp: protocol', () => {
expect(utils.isSafeUrl('ftp://example.com/file')).toBe(false);
test('Should allow ftp: protocol', () => {
expect(utils.isSafeUrl('ftp://example.com/file')).toBe(true);
});

test('Should allow mailto: protocol', () => {
expect(utils.isSafeUrl('mailto:user@example.com')).toBe(true);
});

test('Should allow tel: protocol', () => {
expect(utils.isSafeUrl('tel:+1234567890')).toBe(true);
});

test('Should block custom: protocol', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/react-charting/src/utilities/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2557,7 +2557,7 @@ const truncateTextToFitWidth = (text: string, maxWidth: number, measure: (s: str

export function isSafeUrl(href: string): boolean {
if (/^[a-z][a-z0-9+.-]*:/i.test(href)) {
return /^https?:/i.test(href);
return /^(https?|mailto|tel|ftp):/i.test(href);
}

return true;
Expand Down
12 changes: 10 additions & 2 deletions packages/charts/react-charts/library/src/utilities/UtilityUnitTests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,8 +1569,16 @@ describe('isSafeUrl', () => {
expect(utils.isSafeUrl('file:///etc/passwd')).toBe(false);
});

test('Should block ftp: protocol', () => {
expect(utils.isSafeUrl('ftp://example.com/file')).toBe(false);
test('Should allow ftp: protocol', () => {
expect(utils.isSafeUrl('ftp://example.com/file')).toBe(true);
});

test('Should allow mailto: protocol', () => {
expect(utils.isSafeUrl('mailto:user@example.com')).toBe(true);
});

test('Should allow tel: protocol', () => {
expect(utils.isSafeUrl('tel:+1234567890')).toBe(true);
});

test('Should block custom: protocol', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/react-charts/library/src/utilities/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2713,7 +2713,7 @@ const truncateTextToFitWidth = (text: string, maxWidth: number, measure: (s: str

export function isSafeUrl(href: string): boolean {
if (/^[a-z][a-z0-9+.-]*:/i.test(href)) {
return /^https?:/i.test(href);
return /^(https?|mailto|tel|ftp):/i.test(href);
}
return true;
}
Loading