fixed voice controll accessibility issue#36292
Open
v-baambati wants to merge 5 commits into
Open
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -594,7 +594,7 @@ export const GroupedVerticalBarChart: React.FC<GroupedVerticalBarChartProps> = R | |||
| onClick={pointData.onClick} | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 5 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 967 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 159 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 39 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 73 | Changed |
krkshitij
reviewed
Jun 9, 2026
AtishayMsft
reviewed
Jun 11, 2026
| onFocus={_showToolTipOnSegment && point.legend !== '' ? event => _hoverOn(event, xValue, point) : undefined} | ||
| role="img" | ||
| aria-label={_getAriaLabel(point)} | ||
| role={index !== placeholderIndex ? 'option' : ''} |
Contributor
There was a problem hiding this comment.
default role should be img
Contributor
Author
There was a problem hiding this comment.
list box not allowing us to keep img role for its children
AtishayMsft
reviewed
Jun 11, 2026
| const keyVal = _uniqLineText + '_' + index; | ||
| const rawLegendVal = points!.chartData?.[0]?.legend || 'Series'; | ||
| const legendVal = | ||
| rawLegendVal |
Contributor
Author
There was a problem hiding this comment.
Aria-label will be something like below
EX: one, bar 1 of 3 with 2 data points
krkshitij
reviewed
Jun 12, 2026
| return ( | ||
| <g | ||
| role="listbox" | ||
| aria-label={chartGroupAriaLabel} |
Contributor
There was a problem hiding this comment.
Here, <g> represents an x-axis category group and not a series/legend
krkshitij
reviewed
Jun 12, 2026
| {lineBorders.length > 0 ? <g>{lineBorders}</g> : null} | ||
| {lines.length > 0 ? <g>{lines}</g> : null} | ||
| <g>{dots}</g> | ||
| <g role="listbox" aria-label={chartGroupAriaLabel}> |
Contributor
There was a problem hiding this comment.
Assign listbox role to the dotGroups instead. Each dotGroup contains data points of only 1 line series.
krkshitij
reviewed
Jun 12, 2026
| <g | ||
| role="listbox" | ||
| id={keyVal} | ||
| aria-label={chartGroupAriaLabel} |
Contributor
There was a problem hiding this comment.
Here, <g> represents a single horizontal bar (a primary bar + an optional placeholder bar) so no need to mention the number of data points in aria-label.
krkshitij
reviewed
Jun 12, 2026
| return ( | ||
| <> | ||
| <g>{_bars}</g> | ||
| <g role="listbox" aria-label={chartGroupAriaLabel}> |
Contributor
There was a problem hiding this comment.
Here, <g> contains all the bars. It would be better to create a <g> for all bars in each y-group.
krkshitij
reviewed
Jun 12, 2026
| <> | ||
| <g {..._arrowNavigationAttributes}>{_bars}</g> | ||
| <g> | ||
| <g role="listbox" aria-label={chartGroupAriaLabel} {..._arrowNavigationAttributes}> |
Contributor
There was a problem hiding this comment.
Here, <g> contains all the bars. Assign listbox role to the <g> representing each stack instead.
krkshitij
reviewed
Jun 12, 2026
| <g role="listbox" aria-label={chartGroupAriaLabel} {..._arrowNavigationAttributes}> | ||
| {_bars} | ||
| </g> | ||
| <g role="listbox" aria-label={lineGroupAriaLabel}> |
Contributor
There was a problem hiding this comment.
Here, <g> contains data points from all line series. It would be better to create a <g> for each line series.
krkshitij
reviewed
Jun 12, 2026
| _yMin = Math.min(d3Min(_points, (point: VerticalBarChartDataPoint) => point.y)!, props.yMinValue || 0); | ||
| const legendBars: JSXElement = _getLegendData(_points); | ||
| const legendVal = _points[0]?.legend || 'Series'; | ||
| const chartGroupAriaLabel = `${legendVal}, bar chart with ${_points.length} bars and ${_points.length} data points.`; |
Contributor
There was a problem hiding this comment.
No need to include chart related details here. Some of these details are already included in the chart title. Ensure that the aria label only contains info about what the <g> represents. Try not to repeat them. Do the same for other charts as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.