deps: bump go to 1.25.10 to fix GO-2026-4971 and GO-2026-4918#752
Merged
Conversation
shueybubbles
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Govulncheck is failing on PRs (e.g. #751) with two stdlib vulnerabilities present in go 1.25.9:
net.Dial/LookupPorton Windows when handling NUL byte. Fixed innet@go1.25.10.net/httpHTTP/2 transport on badSETTINGS_MAX_FRAME_SIZE. Fixed innet/http@go1.25.10.Root Cause
The Go toolchain version (
go.moddirective andgo-versioninputs in workflows) is hardcoded as1.25.9and is not maintained by Dependabot:gomodecosystem does not update thegodirective.github-actionsecosystem does not update arbitrarywith:string inputs likego-version.So nobody bumps these. Stdlib CVEs require manually advancing the toolchain.
Solution
Bump the toolchain patch version from
1.25.9to1.25.10in:go.mod.github/workflows/pr-validation.yml.github/workflows/golangci-lint.ymlStaying on the
1.25minor line to keep the change minimal. The devcontainer Dockerfile only pins the major.minor (1.25), so the version-alignment check still passes without changes there.Changes
go.modgo 1.25.9->go 1.25.10.github/workflows/pr-validation.ymlgo-version: '1.25.9'->'1.25.10'.github/workflows/golangci-lint.ymlgo-version: '1.25.9'->'1.25.10'Testing
go build ./...passes locally with the auto-downloadedgo1.25.10toolchain.Related