Conversation
Collaborator
Author
|
Note that this PR took some updating of the smoke test config to use newer model (4.1) and parameters around that. While setting that I ended up cleaning out a bunch of old references to env vars that either weren't used anymore or where in the GitHub secrets but aren't actually "secrets" |
dworthen
approved these changes
Oct 6, 2025
Brandsma
pushed a commit
to ThalamusLabs/MMGraphRAG
that referenced
this pull request
Nov 6, 2025
* Fix scope for Azure auth with LiteLLM * Change internal language on max_attempts to max_retries * Rework model config connectivity validation * Semver * Swtich smoke tests to LiteLLM * Take out temporary retry_strategy = none since it is not fnllm compatible * Bump smoke test timeout * Bump smoke timeout further * Tune smoke params * Update smoke test bounds * Remove covariates from min-csv smoke * Smoke: adjust communities, remove drift * Remove secrets where they aren't necessary * Clean out old env var references
JonasReuter
pushed a commit
to JonasReuter/graphrag
that referenced
this pull request
Apr 13, 2026
* Fix scope for Azure auth with LiteLLM * Change internal language on max_attempts to max_retries * Rework model config connectivity validation * Semver * Swtich smoke tests to LiteLLM * Take out temporary retry_strategy = none since it is not fnllm compatible * Bump smoke test timeout * Bump smoke timeout further * Tune smoke params * Update smoke test bounds * Remove covariates from min-csv smoke * Smoke: adjust communities, remove drift * Remove secrets where they aren't necessary * Clean out old env var references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an auth issue with LiteLLm when providing custom scope. LiteLLM does not like the
audienceparameter our config uses, instead usingazure_scope.I also reworded
max_attemptsasmax_retriesto reflect the logic, and reworked the model config connectivity test to loop through all dict items and check any from our known type set.