Storage fixes and cleanup #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
natoverse
commented
Nov 4, 2025
natoverse
commented
- Fixes recursion and filtering issue in blobs
- Simplifies API by removing unused params
- Removes base_dir - this was not used and should use what is sent during init anyway
- Removes max_count - this was never used, and should use a proper paging mechanism if we want it
- Cleans up config defaults and validation
Collaborator
Author
|
Fixes #2115 |
gaudyb
reviewed
Nov 4, 2025
gaudyb
reviewed
Nov 4, 2025
dworthen
reviewed
Nov 5, 2025
dworthen
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.