VSMB fix bugcheck by keeping handle open to empty default share #2591
Conversation
Signed-off-by: Pooja Mahadev Soundalgekar <pomahade@microsoft.com>
| } | ||
|
|
||
| const ( | ||
| device = `\\?\GLOBALROOT\Device\vmsmb\VSMB-{dcc079ae-60ba-4d07-847c-3493609c0870}\defaultEmptyShare` |
There was a problem hiding this comment.
will \\\\?\\VMSMB\\VSMB-{dcc079ae-60ba-4d07-847c-3493609c0870}\defaultEmtpyShare result in the same? We have vsmbSharePrefix defined under internal/uvm/vsmb.go, so I wonder if you can reuse that?
There was a problem hiding this comment.
Does not seem to work on testing.
| sidecar "github.com/Microsoft/hcsshim/internal/gcs-sidecar" | ||
| ) | ||
|
|
||
| var vsmbKeepAliveHandle windows.Handle |
There was a problem hiding this comment.
is this strictly necessary? you may have the VsmbMain function return a handle, instead of passing a pointer in. Also, as we're finalizing this feature, you may want to consider returning an error in case we fail to setup LMR/dummy share, instead of silently failing as we do now.
There was a problem hiding this comment.
This is to make the handle global so it's available until end of process. We do add error log inside vsmb.go in failure case, whats the point of returning an error?
3 participants
No description provided.