Skip to content

Fix 9p client#835

Open
CvvT wants to merge 9 commits into
mainfrom
weiteng/fix_9p
Open

Fix 9p client#835
CvvT wants to merge 9 commits into
mainfrom
weiteng/fix_9p

Conversation

@CvvT
Copy link
Copy Markdown
Contributor

@CvvT CvvT commented May 7, 2026

This PR fixes multiple issues in the 9p client reported by Hyenas.

  1. Previously we assumed the 9p server should be trusted, but it may not hold in the broker setup. Add input validation at various places.
  2. Fix tag number wraparound issue.
  3. Fix fid leak: in clunk, fid is removed from the server side even if server returns an error.
  4. Refcounted Fid handles: a potential race issue may happen if one thread is trying to close a fid and create a new fid while another thread is using that fid. Although unlikely, we may reuse the closed fid and cause the second thread to read the wrong file.
  5. Fix race issue on file offset update

@CvvT CvvT marked this pull request as ready for review May 7, 2026 20:43
@github-actions
Copy link
Copy Markdown

🤖 SemverChecks 🤖 No breaking API changes detected

Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant