Revise OP-TEE ShmInfo to ensure byte-length bound check#836
Open
sangho2 wants to merge 2 commits into
Open
Conversation
2cbc7a3 to
38378ff
Compare
|
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises OP-TEE shim's
ShmInfoto ensure byte-length bound check. Previously,ShmInfoonly maintained an array of physical addresses and a start offset, such that its bound check was coarse-grained. A fine-grained check is needed to avoid confused-deputy attacks (i.e., preventing VTL1 kernel from corrupting some VTL0 bytes due to a page/byte gap).