Skip to content

Revise OP-TEE ShmInfo to ensure byte-length bound check#836

Open
sangho2 wants to merge 2 commits into
mainfrom
sanghle/optee/mem-filter
Open

Revise OP-TEE ShmInfo to ensure byte-length bound check#836
sangho2 wants to merge 2 commits into
mainfrom
sanghle/optee/mem-filter

Conversation

@sangho2
Copy link
Copy Markdown
Contributor

@sangho2 sangho2 commented May 7, 2026

This PR revises OP-TEE shim's ShmInfo to ensure byte-length bound check. Previously, ShmInfo only maintained an array of physical addresses and a start offset, such that its bound check was coarse-grained. A fine-grained check is needed to avoid confused-deputy attacks (i.e., preventing VTL1 kernel from corrupting some VTL0 bytes due to a page/byte gap).

@sangho2 sangho2 force-pushed the sanghle/optee/mem-filter branch from 2cbc7a3 to 38378ff Compare May 7, 2026 02:30
@sangho2 sangho2 marked this pull request as ready for review May 7, 2026 02:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/method_parameter_count_changed.ron

Failed in:
  litebox_shim_optee::msg_handler::ShmInfo::new takes 2 parameters in /home/runner/work/litebox/litebox/target/semver-checks/git-main/9994096a84e94f5a24349977a7bb888f46aca148/litebox_shim_optee/src/msg_handler.rs:604, but now takes 3 parameters in /home/runner/work/litebox/litebox/litebox_shim_optee/src/msg_handler.rs:618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant