Skip to content

Conversation

@cnaples79
Copy link

@cnaples79 cnaples79 commented Dec 9, 2025

Summary

  • add PEP 561 py.typed marker so type checkers see bundled stubs
  • include marker in package_data for distribution

Rationale

Changes

  • add mssql_python/py.typed
  • ship py.typed via setup.py package_data

Fixes #359

@sumitmsft
Copy link
Contributor

Hi @cnaples79

Thank you for raising this PR, appreciate your efforts. We will review the PR and share our comments (if any).

Please allow us a few days' time to get back on this. We will assign it to the appropriate engineer by tomorrow.

Regards,
Sumit

@bewithgaurav
Copy link
Collaborator

Hi @cnaples79 - Thanks for raising this.. The PR looks good to go!
Requesting you to resolve the conflicts so that we can start CI pipelines and merge this off, please let us know if you have any queries.

Copy link
Collaborator

@bewithgaurav bewithgaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved before merge, else lgtm

@bewithgaurav bewithgaurav self-assigned this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library Missing Stub File Typed

3 participants