CHORE: Upgrade bundled ODBC driver from 18.5.1.1 to 18.6.2.1#569
Open
gargsaumya wants to merge 2 commits into
Open
CHORE: Upgrade bundled ODBC driver from 18.5.1.1 to 18.6.2.1#569gargsaumya wants to merge 2 commits into
gargsaumya wants to merge 2 commits into
Conversation
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changes
Summary
📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.build._deps.simdutf-src.src.haswell.implementation.cpp: 0.4%
mssql_python.pybind.build._deps.simdutf-src.src.implementation.cpp: 6.7%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.implementation.h: 10.4%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.scalar.utf16_to_utf8.utf16_to_utf8.h: 25.3%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.7%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.internal.isadetection.h: 65.3%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 74.2%🔗 Quick Links
|
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the bundled Microsoft ODBC Driver for SQL Server from 18.5.1.1 to 18.6.2.1 across all supported platforms (Windows x64/x86/arm64, macOS x86_64/arm64, Linux debian_ubuntu/rhel/alpine/suse for x86_64 and arm64). Updates the binary references, CI download URLs/verification commands, and license/release-notes files that ship with the wheel.
Changes:
- Update Linux
.sofilename fromlibmsodbcsql-18.5.so.1.1tolibmsodbcsql-18.6.so.2.1inddbc_bindings.cpp,test_000_dependencies.py,build.sh, and the pipelinelddchecks. - Update PR validation pipeline to download the new MSI (linkid 2358430) and the new Alpine
msodbcsql18_18.6.2.1-1APKs/signatures (new download path0b3d5518-...). - Replace bundled Windows/macOS/Linux license files and macOS/Linux release-notes for the new driver version, and add a new license file for
linux/suse/x86_64.
Reviewed changes
Copilot reviewed 18 out of 53 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| mssql_python/pybind/ddbc_bindings.cpp | Updates Linux driver .so filename in GetDriverPathCpp. |
| mssql_python/pybind/build.sh | Updates patchelf example comment to new .so name. |
| tests/test_000_dependencies.py | Updates expected driver .so filename in three locations. |
| eng/pipelines/pr-validation-pipeline.yml | Updates MSI/APK URLs, package filenames, and ldd paths to 18.6.2.1; trailing blank lines added. |
| mssql_python/libs/windows/{x64,x86,arm64}/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Updated EULA text — but all non-ASCII chars are mojibake (�). |
| mssql_python/libs/macos/{x86_64,arm64}/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Same EULA mojibake issue. |
| mssql_python/libs/macos/{x86_64,arm64}/share/doc/msodbcsql18/RELEASE_NOTES | Prepends 18.6.x changelog entries. |
| mssql_python/libs/linux/alpine/arm64/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Updated EULA text — non-ASCII chars are mojibake. |
| mssql_python/libs/linux/alpine/x86_64/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Content replaced with RELEASE_NOTES changelog instead of EULA. |
| mssql_python/libs/linux/rhel/{x86_64,arm64}/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Content replaced with RELEASE_NOTES changelog instead of EULA. |
| mssql_python/libs/linux/debian_ubuntu/{x86_64,arm64}/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | Content replaced with RELEASE_NOTES changelog instead of EULA. |
| mssql_python/libs/linux/suse/x86_64/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt | New file; EULA text with the same mojibake issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gargsaumya
force-pushed
the
saumya/upgrade-odbc
branch
from
a7d4057 to
72e52f1
Compare
gargsaumya
force-pushed
the
saumya/upgrade-odbc
branch
from
710e464 to
bbae95a
Compare
| # TODO: Linux-specific: use patchelf to set RPATH of the driver .so file | ||
| # Currently added Driver SO files right now are already patched | ||
| # patchelf --set-rpath '$ORIGIN' libmsodbcsql-18.5.so.1.1 | ||
| # patchelf --set-rpath '$ORIGIN' libmsodbcsql-18.6.so.2.1 |
Comment on lines
+36
to
+37
| ii. modify or distribute the source code of any distributable code so that any part of it becomes subject to any license that requires that the distributable | ||
| code, any other part of the software, or any of Microsoft’s other intellectual property be disclosed or distributed in source code form, or that others have the right to modify it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request updates the project to use Microsoft ODBC Driver 18.6.2.1 for SQL Server instead of 18.5.x and updates the associated license file. The changes ensure that all references, downloads, and verifications in the CI pipeline are aligned with the new driver version, and the license file includes additional clarifications and regional information.
ODBC Driver Version Update:
eng/pipelines/pr-validation-pipeline.ymlto use ODBC Driver 18.6.2.1 instead of 18.5.x for all supported platforms and architectures. [1] [2] [3] [4] [5] [6] [7] [8] [9]License File Update:
MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txt, including more detailed distribution rights, restrictions, and limitations, as well as additional regional variations and French translations for Canadian users. [1] [2] [3]