Skip to content

chore: resolve Object langAliases in function argument types #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 2 commits into from
Apr 9, 2026
+8 −5
Merged

chore: resolve Object langAliases in function argument types #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979f4a9
chore: resolve Object langAliases in function argument types
yury-s Apr 9, 2026
4cf4003
roll beta driver
yury-s Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<name>Playwright Client Examples</name>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<playwright.version>1.58.0</playwright.version>
<playwright.version>1.59.0</playwright.version>
</properties>
<dependencies>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.59.1-beta-1775752988000
1.59.1-beta-1775762078000
9 changes: 6 additions & 3 deletions tools/api-generator/src/main/java/com/microsoft/playwright/tools/ApiGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,12 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
}
return "Map<" + convertTemplateParams(jsonType) + ">";
}
if ("Map".equals(name)) {
Expand All @@ -525,9 +531,6 @@ private String convertBuiltinType(JsonObject jsonType) {
if ("WebSocketRoute.onClose.handler".equals(jsonPath)) {
return "BiConsumer<Integer, String>";
}
if ("Screencast.start.options.onFrame".equals(jsonPath)) {
return "Consumer<ScreencastFrame>";
}
if (jsonType.getAsJsonArray("args").size() == 1) {
String paramType = convertBuiltinType(jsonType.getAsJsonArray("args").get(0).getAsJsonObject());
if (!jsonType.has("returnType") || jsonType.get("returnType").isJsonNull()) {
Expand Down
Loading