fix: skip test registrations from ESM preflight imports #39177
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When external ESM loaders like
tsx/esmare used alongside Playwright (viaimport 'tsx/esm'in config), they intercept Playwright's.esm.preflightimport requests and execute the actual test file content instead of returning empty content. This causes:test()calls to run twice (once during preflight, once during actual import)Reproduction: https://github.com/Abhinegi2/playwright-issue
Solution
Check if the registration location file path ends with
.esm.preflightin_currentSuite()and returnundefinedto skip registration. This ensures tests registered during external loader's preflight phase are silently ignored.Testing
Verified the fix works by:
Related
Fixes #39172