chore: support opening .trace files via .link indirection#39975
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Mar 31, 2026
Merged
chore: support opening .trace files via .link indirection#39975pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
yury-s
approved these changes
Mar 31, 2026
| if (fs.existsSync(linkFile)) { | ||
| const tracePath = await fs.promises.readFile(linkFile, 'utf-8'); | ||
| traceDir = path.dirname(tracePath); | ||
| traceFile = path.basename(tracePath); |
Member
There was a problem hiding this comment.
maybe support path to a dir too?
pavelfeldman
force-pushed
the
trace-link-file
branch
from
0313ca5 to
1699de6
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Mar 31, 2026
pavelfeldman
added a commit
that referenced
this pull request
Mar 31, 2026
Contributor
Test results for "MCP"1 failed 6298 passed, 370 skipped Merge workflow run. |
Contributor
Test results for "tests 1"3 flaky39111 passed, 846 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tracefile (not a.zip), create a.linkfile pointing to the original instead of extractingloadTrace()checks for.linkand loads from the linked locationtraceLoader.load()accept optionaltraceFilefilter and optionalunzipProgress