feat(har): add _resourceType to all requests#41077
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Jun 1, 2026
| expect(tail.toString()).toMatch(/\}\s*\}\s*$/); | ||
| }); | ||
|
|
||
| it.describe('should record resource type', () => { |
Member
There was a problem hiding this comment.
I'd keep the number of tests minimal for this field, just one test maybe with a few resource types should be sufficient. There are no usages at the moment except for "websocket" and with agents our test suite has been growing too fast which makes CI jobs run increasingly longer.
dcrousso
force-pushed
the
feat-har-_resourceType
branch
from
912192d to
e278a5f
Compare
dcrousso
force-pushed
the
feat-har-_resourceType
branch
from
e278a5f to
0edef5b
Compare
Contributor
Test results for "MCP"7230 passed, 1103 skipped Merge workflow run. |
Contributor
Test results for "tests 1"7 flaky39452 passed, 775 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a followup for #41015 (comment)