fix(fileUpload): reject localPaths when client is not collocated with server#41080
Open
pavelfeldman wants to merge 1 commit into
Open
fix(fileUpload): reject localPaths when client is not collocated with server#41080pavelfeldman wants to merge 1 commit into
pavelfeldman wants to merge 1 commit into
Conversation
… server Introduce `isClientCollocatedWithServer` on the Playwright options and throw in `prepareFilesForUpload` when `localPaths` is passed without it. Rename `_isCollocatedWithServer` to `_isBrowserCollocatedWithServer` and the dispatcher's `isLocal` to `isInProcess` to disambiguate browser/client/server collocation.
Contributor
Test results for "MCP"7230 passed, 1103 skipped Merge workflow run. |
yury-s
approved these changes
Jun 1, 2026
Contributor
Test results for "tests 1"6 flaky39447 passed, 775 skipped Merge workflow run. |
yury-s
reviewed
Jun 1, 2026
| try { | ||
| const cdpBrowser1 = await browserType.connectOverCDP(`http://127.0.0.1:${port}/`); | ||
| expect(toImpl(cdpBrowser1)._isCollocatedWithServer).toBe(false); | ||
| expect(toImpl(cdpBrowser1)._isBrowserCollocatedWithServer).toBe(false); |
Member
There was a problem hiding this comment.
add a check for isClientCollocated... too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepareFilesForUploadwhenlocalPathsis provided but the client is not collocated with the server.isClientCollocatedWithServerto Playwright options; renameBrowser._isCollocatedWithServer→_isBrowserCollocatedWithServerandDispatcherConnection'sisLocal→isInProcessto disambiguate collocation flavors.