Skip to content

feat(har): use engine timestamps instead of server Date#41082

Open
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:feat-har-browser-startedDateTime
Open

feat(har): use engine timestamps instead of server Date#41082
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:feat-har-browser-startedDateTime

Conversation

@dcrousso
Copy link
Copy Markdown
Contributor

@dcrousso dcrousso commented Jun 1, 2026

whether it be from a dedicated protocol timestamp or the more general timing , we should use a value from the engine for startDateTime instead of the playwright server Date

@dcrousso dcrousso requested review from pavelfeldman and yury-s June 1, 2026 21:45
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dcrousso dcrousso force-pushed the feat-har-browser-startedDateTime branch from e715204 to 9417408 Compare June 1, 2026 23:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Test results for "MCP"

1 failed
❌ [chrome] › mcp/launch.spec.ts:64 › persistent context @mcp-ubuntu-latest-chrome

7229 passed, 1103 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:647 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:337 › screencast › should work for popups `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/har-websocket.spec.ts:170 › should record websocket connection failure `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:704 › should indicate current test status `@windows-latest-node20`

39459 passed, 775 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant