Fix crash attempting to get runtime when shutting down instance#16238
Merged
Conversation
dannyvv
approved these changes
Jun 9, 2026
vmoroz
approved these changes
Jun 9, 2026
tido64
approved these changes
Jun 10, 2026
acoates-ms
force-pushed
the
crashjsinitshutdownmain
branch
from
4b68d13 to
1ba64fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the instance is shutting down, the runtime can be cleared on the instance while JS code is running. If the JS triggers a turbomodule with a JSI Init function, then when it attempts to get the runtime to call the REACT_INIT function with it will crash.
Fix is to simply skip the REACT_INIT function if we are already shutting down the instance.
Microsoft Reviewers: Open in CodeFlow