perf: Batch SQLite INSERTs for indexing pipeline

[KRRT7]

Stack: 3/4 — depends on #229. Merge #231, #229, then this PR.

---

• Add add_terms_batch and add_properties_batch to ITermToSemanticRefIndex and IPropertyToSemanticRefIndex interfaces
• SQLite backend uses executemany instead of individual cursor.execute() calls (~1000+ calls per indexing batch reduced to 2-3)
• Restructure add_metadata_to_index_from_list and add_to_property_index to collect all data first (pure functions), then batch-insert
• Memory backend implements batch methods as loops for interface compatibility

Benchmark

Azure Standard_D2s_v5 -- 2 vCPU, 8 GiB RAM, Python 3.13

Indexing Pipeline (pytest-async-benchmark pedantic, 20 rounds, 3 warmup)

Only the hot path (add_messages_with_indexing) is timed -- DB creation, storage init, and teardown are excluded.

Benchmark	Before (min)	After (min)	Speedup
add_messages_with_indexing (200 msgs)	28.8 ms	25.0 ms	1.16x
add_messages_with_indexing (50 msgs)	7.8 ms	6.7 ms	1.16x
VTT ingest (40 msgs)	6.9 ms	6.1 ms	1.14x

Consistent ~14-16% improvement -- executemany amortizes per-call overhead.

Reproduce the benchmark locally

Save the benchmark file below as tests/benchmarks/test_benchmark_indexing.py, then:

pip install 'pytest-async-benchmark @ git+https://github.com/KRRT7/pytest-async-benchmark.git@feat/pedantic-mode' pytest-asyncio

# Run on main
git checkout main
python -m pytest tests/benchmarks/test_benchmark_indexing.py -v -s

# Run on this branch
git checkout perf/batch-inserts
python -m pytest tests/benchmarks/test_benchmark_indexing.py -v -s

---

Generated by codeflash optimization agent

[gvanrossum]

Thanks for this! It requires more review time than I have right now, so I'll keep it open until I have more time.

[bmerkle]

Hi @KRRT7
I was asked by @gvanrossum to do a review of this PR
Please find attached some comments.

There are also some pre-existing issues in these files, so things which have not be introduced by this PR, but i would suggest that we cover those in a future, seperate PR.
I have only mentioned the code duplicate, which could possibly be fixed also in this PR.

please let me know what you think.

[KRRT7]

Hi @KRRT7
I was asked by @gvanrossum to do a review of this PR

Thanks! I'll take a closer look to your reviews this afternoon.

[bmerkle]

Hi @KRRT7 can you please review the open comments from me ? Thanks :-)

[bmerkle]

@KRRT7 please check my comments

[KRRT7]

@bmerkle Thanks for the thorough review — all comments addressed in 9ae667f. Summary:

• Fixed inverse_actions bug — both add_metadata_to_index_from_list (regression) and add_metadata_to_index (pre-existing) now index inverse actions
• Eliminated code duplication — deleted add_entity_to_index, add_action_to_index, add_topic_to_index, and text_range_from_location (were duplicates of add_entity/add_action/add_topic/text_range_from_message_chunk). Reduced from 3 parallel paths to 2. Updated all callers and tests.
• Moved imports to top-level in sqlite/propindex.py per AGENTS.md

make check test format passes (479/479 offline tests green, 3 failures are API rate-limits).

Ready for re-review.