Port TS PR 61505 - Cache mapper instantiations#1358
Merged
jakebailey merged 4 commits intomainfrom Jul 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports TypeScript’s PR 61505 to introduce caching for type mapper instantiations, aiming to reduce repeated instantiation overhead and improve performance.
- Added a stack of active mappers with per-mapper caches backed by
sync.Pool. - Updated
instantiateTypeWithAliasto check and store in those caches. - Cleared mapper caches after each inference in
getInferredType.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/checker/inference.go | Inserted clearActiveMapperCaches() after each inference loop |
| internal/checker/checker.go | Added activeMappers, activeTypeMappersCaches, cache logic in instantiateTypeWithAlias, and push/pop/clear helper methods |
Comments suppressed due to low confidence (2)
internal/checker/inference.go:1332
- [nitpick]
clearActiveMapperCaches()is invoked inside the loop for each inference, leading to repeated map clears. Consider moving this call outside the loop or only once per context to avoid redundant operations.
c.clearActiveMapperCaches()
Contributor
jakebailey
commented
Jul 7, 2025
jakebailey
commented
Jul 7, 2025
Comment on lines
+859
to
+860
| activeMappers []*TypeMapper | ||
| activeTypeMappersCaches []map[string]*Type |
Member
Author
There was a problem hiding this comment.
The other "global" caches don't use two separate lists in the Go port, instead scoping them together, but I'm keeping them separate since I'm trying to reuse the maps.
DanielRosenwasser
approved these changes
Jul 7, 2025
DanielRosenwasser
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is an early port of microsoft/TypeScript#61505, because I like to go fast
Calculating the key increases allocs by a bit (really wish we had the yet-to-exist Go custom map implementation), but for https://github.com/AnswerOverflow/AnswerOverflow/tree/1ab687793a598789a0c86b4ca5f17ee6f3a256aa/apps/dashboard:
TypeScript 5.8 vs 5.9:
tsgo main vs this PR;
(Instantiations look higher than 5.8 or 5.9 because tsgo's metrics sum up instantiations between all concurrent checkers)