Implement TS5011 migration diagnostic for common source directory mismatch #2709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsgo silently emits files next to source instead of
outDirwhenincludereferences parent directories (e.g.,../common/src/**/*). The submodule TypeScript 6.0 has the same output path behavior but emits TS5011 telling the user to setrootDirexplicitly. The Go port was missing this diagnostic entirely, making the misconfiguration invisible.Changes
internal/outputpaths/commonsourcedirectory.go: AddedGetComputedCommonSourceDirectory— public wrapper matching TypeScript'sgetComputedCommonSourceDirectory, computes common source dir from file list rather than config file pathinternal/compiler/program.go: Implemented the TS5011 migration check from TypeScript 6.0. When!noEmit && !composite && !rootDir && configFilePath && (outDir || declarationDir || outFile), compares the config-file-based common source directory against the file-computed one. If they differ, emits TS5011 with chained migration URL diagnosticinternal/execute/tsctests/tsc_test.go: AddedTestTscOutDirWithParentDirIncludereproducing the reported scenarioRepro
Before:
common/src/greeter.jsemitted next to source with exit code 0.After: TS5011 error emitted matching submodule TypeScript behavior.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.