Preserve original comments on params in dts generated by pseudo type node builder under removeComments: false#3263
Open
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Open
Conversation
…node builder under removeComments: false
jakebailey
reviewed
Mar 27, 2026
internal/pseudochecker/lookup.go
Outdated
Comment on lines
+665
to
+667
| parameter.DotDotDotToken != nil, | ||
| e.Name(), | ||
| e.AsParameterDeclaration().QuestionToken != nil || e.AsParameterDeclaration().Initializer != nil, | ||
| ch.typeFromParameter(e.AsParameterDeclaration()), | ||
| parameter.QuestionToken != nil || parameter.Initializer != nil, |
Member
There was a problem hiding this comment.
At some level, why even have any of these if we are ferrying along the declaration?
(Or, why not just use p.Name.Parent more above?)
Contributor
Author
There was a problem hiding this comment.
At some level, why even have any of these if we are ferrying along the declaration?
ye, u are right here - since the new addition most of those other fields can just be read directly from the Declaration. I made that change.
Or, why not just use p.Name.Parent more above?
I thought about that but that felt indirect and not matching the style of all of those other fields on pseudochecker structs
Member
|
At some level, I wonder if this is even worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.