Accepted symbol baselines#4007
Conversation
| compiler/nodeNextCjsNamespaceImportDefault1.symbols.diff | ||
| compiler/nodeNextCjsNamespaceImportDefault2.symbols.diff | ||
|
|
||
| # Declaration position `(file, --, --)` changed to actual numeric positions |
There was a problem hiding this comment.
(file, --, --) is sanitized lib refs so changes to lib positions don't affect baselines - are these missing lib bindings, or are we failing to sanitize? Both seem bad.
|
|
||
| # `.constructor` property access now resolves to `Object.constructor` from lib | ||
| ## Accessing `.constructor` on a class type now correctly resolves to the inherited `Object.constructor` symbol | ||
| conformance/typesWithPrivateConstructor.symbols.diff |
There was a problem hiding this comment.
In strada we filtered these from the .symbol output - why?
| conformance/typesWithProtectedConstructor.symbols.diff | ||
|
|
||
| # Import specifier in re-exports resolves to alias target symbol name | ||
| ## In `import { x as y }`, the symbol for `x` now reports as the target name `y`. Either is arguably correct. |
There was a problem hiding this comment.
All of these "we're using the local name for the thing instead of the target's globally accessible/local name" things all track back to possible diffs in name lookup behavior. The new behavior seems "better" since it respects locals more, though figuring out why there's a diff might be informative.
| conformance/nodeModulesSynchronousCallErrors(module=nodenext).symbols.diff | ||
|
|
||
| # Test baseline reduction (removed extra file outputs) | ||
| ## This test has an error, fix later. |
There was a problem hiding this comment.
Uh, doesn't this mean it should be in the to-triage set, not "accepted"?
|
|
||
| # Additional Decl entries for multi-declaration function symbols | ||
| ## `flatMap` function with multiple declarations now shows all Decl entries on the symbol | ||
| conformance/templateInsideCallback.symbols.diff |
There was a problem hiding this comment.
This just belongs in the @overload JSDoc tags now contribute Decl entries to the host function/method symbol group.
Bugs / investigation sections to come in a later PR