Skip to content

Respect table order #9763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timotheeguerin merged 1 commit into from
Feb 21, 2026
Merged

Respect table order #9763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions packages/spec-dashboard/src/apis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,25 @@ export async function getCoverageSummaries(
emitterNames?: string[];
}> = [];

for (const manifest of manifests) {
if (options.tables && options.tables.length > 0) {
// Use table definitions to split scenarios
const splitResults = splitManifestByTables(manifest, options.tables);
allManifests.push(...splitResults);
} else {
// No table definitions, use default behavior
if (options.tables && options.tables.length > 0) {
// Split each manifest by its table definitions, then reorder to match configured table order
const splitResults = manifests.flatMap((m) => splitManifestByTables(m, options.tables!));
const resultByTableName = new Map(splitResults.map((r) => [r.tableName, r]));

for (const table of options.tables) {
const match = resultByTableName.get(table.name);
if (match) {
allManifests.push(match);
resultByTableName.delete(table.name);
}
}
// Append any remaining entries (unmatched scenarios with default table names)
for (const remaining of resultByTableName.values()) {
allManifests.push(remaining);
}
} else {
// No table definitions, use default behavior
for (const manifest of manifests) {
allManifests.push({
manifest,
tableName: manifest.displayName || manifest.packageName || "",
Expand Down
Loading