Open
Conversation
bobbrow
commented
Apr 3, 2026
sean-mcmanus
reviewed
Apr 4, 2026
sean-mcmanus
reviewed
Apr 4, 2026
Colengms
requested changes
Apr 6, 2026
Member
Author
|
@WardenGnaw had some feedback about dealing with some of the other properties in the launch.json config and shared a commit in MIEngine where these things might have been handled. The cases where the config asks for something other than a local launch of a program should be handled in some way (either fail the launch session or fall back to regular debugging mode). |
Colengms
requested changes
Apr 7, 2026
Extension/test/scenarios/RunWithoutDebugging/tests/runWithoutDebugging.integration.test.ts
Show resolved
Hide resolved
Extension/test/scenarios/RunWithoutDebugging/tests/runWithoutDebugging.integration.test.ts
Show resolved
Hide resolved
Extension/test/scenarios/RunWithoutDebugging/tests/runWithoutDebugging.integration.test.ts
Show resolved
Hide resolved
Extension/test/scenarios/RunWithoutDebugging/tests/runWithoutDebugging.integration.test.ts
Show resolved
Hide resolved
Colengms
previously approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1201
Supports both the Play button in the editor (run active file) and configurations specified in launch.json. macOS support needs to be tested - I don't currently have access to a machine.
Co-authored by GitHub Copilot