Merged
Conversation
- renameFile: use command palette to save instead of TextEditor.save() which fails with ElementNotInteractableError after rename dialog - invisible project: add sleep after workspace switch for UI to settle - Add dismissModalDialogIfPresent() helper to handle modal dialogs (e.g. workspace trust) that block sidebar clicks on Windows CI - Call dialog dismissal in expandInJavaProjects, invisible project test, and java.project.create test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The javaProjectExplorer.focus command may not render the section immediately on Linux. Add retry loop with re-issuing the command. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wenytang-ms
changed the title
chagong
previously approved these changes
Mar 20, 2026
Replace 12 fixed sleep() calls with condition-based polling: - waitForTreeItem / waitForTreeItemGone: poll tree view for item presence - waitForFileExists / waitForFileGone: poll filesystem for file state - waitForModalDialog: poll for dialog appearance with graceful fallback - waitForEditorTitle: poll for editor to show expected file title This makes tests resilient to CI timing variations instead of relying on hardcoded delays that may be too short on slow machines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Use const instead of let for simpleItem (prefer-const) - Add braces to all single-line if statements (curly) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chagong
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.