Preserve <img> alt attribute in comment body preprocessing#8762
Merged
Conversation
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix comments panel to retain img alt attribute
Preserve Jun 1, 2026
<img> alt attribute in comment body preprocessing
alexr00
approved these changes
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the comment-body preprocessing in GHPRComment so that raw HTML <img ...> tags are rewritten into Markdown image syntax while preserving the original alt text (improving how images are labeled in VS Code’s Comments UI).
Changes:
- Makes the
<img ... src="...">matching portion lazy to correctly handle multiple<img>tags on the same line. - Extracts the
alt="..."attribute from the matched<img>tag and uses it in the generated Markdown image text (with a fallback).
Show a summary per file
| File | Description |
|---|---|
src/github/prComment.ts |
Updates <img>-to-Markdown rewriting to preserve alt text and improve multi-image matching on a single line. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
amunger
reviewed
Jun 3, 2026
| @@ -352,8 +353,11 @@ export class GHPRComment extends CommentBase { | |||
| } | |||
|
|
|||
| private replaceImg(body: string) { | |||
There was a problem hiding this comment.
seems like a good place for a unit test
amunger
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments containing raw HTML
<img alt="..." src="...">rendered asImage: imagein the Comments panel becauseGHPRComment.replaceImgrewrote the tag to, discarding the original alt. VS Code's tree viewer honors alt when present, so the fix is purely in the extension's preprocessing.Changes (
src/github/prComment.ts)altfrom the matched tag and use it in the rewritten markdown image, falling back toimagewhen missing or empty.srcportion ofIMG_EXPRESSIONlazy so multiple<img>tags on the same line are matched (and parsed) individually.altextraction works regardless of attribute order sinceIMG_EXPRESSIONmatches the entire<img ...>tag. Markdown image syntax () is unaffected — it never matched the regex to begin with.