-
Notifications
You must be signed in to change notification settings - Fork 105
Normalize debugger path aliases and add a shell launcher #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bschnurr
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
bschnurr:digest-20260515-1428
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| bundled/scripts/noConfigScripts/debugpy text eol=lf | ||
| bundled/scripts/noConfigScripts/debugpy.sh text eol=lf | ||
| bundled/scripts/noConfigScripts/debugpy.fish text eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| description: "Review critic for vscode-python-debugger. Use when: reviewing a fix, checking regressions, verifying test coverage, or pressure-testing a PR before merge." | ||
| tools: [read/readFile, edit/editFiles, execute/runInTerminal, execute/getTerminalOutput, execute/sendToTerminal, search/textSearch, vscode/askQuestions, todo] | ||
| --- | ||
|
|
||
| You are a high-signal review critic for **vscode-python-debugger**. | ||
|
|
||
| Focus on correctness, regressions, environment mutation, debug configuration behavior, cross-platform shell integration, and missing tests. Ignore style unless it hides a real bug. | ||
|
|
||
| ## Review workflow | ||
|
|
||
| 1. Start with `git status --short` and `git diff --stat`, then read every changed file in scope. | ||
| 2. Verify each behavior change has a targeted test, or explain exactly why a test is not practical. | ||
| 3. Prioritize: | ||
| - PATH / Path normalization and environment merging | ||
| - no-config debugging bootstrap scripts across shells | ||
| - debug configuration resolution and workspace behavior | ||
| - Windows/macOS/Linux differences that could break launch or attach | ||
| 4. Report only actionable findings with: | ||
| - severity | ||
| - affected file or scope | ||
| - why it matters | ||
| - the missing fix or missing test | ||
| 5. If the diff looks sound, say so explicitly and cite the tests that support that conclusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #! /bin/bash | ||
| # Bash script | ||
| export DEBUGPY_ADAPTER_ENDPOINTS=$VSCODE_DEBUGPY_ADAPTER_ENDPOINTS | ||
| python3 $BUNDLED_DEBUGPY_PATH --listen 0 --wait-for-client $@ | ||
| export DEBUGPY_ADAPTER_ENDPOINTS="$VSCODE_DEBUGPY_ADAPTER_ENDPOINTS" | ||
| python3 "$BUNDLED_DEBUGPY_PATH" --listen 0 --wait-for-client "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| @echo off | ||
| :: Bat script | ||
| set DEBUGPY_ADAPTER_ENDPOINTS=%VSCODE_DEBUGPY_ADAPTER_ENDPOINTS% | ||
| python %BUNDLED_DEBUGPY_PATH% --listen 0 --wait-for-client %* | ||
| @echo off | ||
| :: Bat script | ||
| set "DEBUGPY_ADAPTER_ENDPOINTS=%VSCODE_DEBUGPY_ADAPTER_ENDPOINTS%" | ||
| python "%BUNDLED_DEBUGPY_PATH%" --listen 0 --wait-for-client %* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| # Fish script | ||
| set -x DEBUGPY_ADAPTER_ENDPOINTS $VSCODE_DEBUGPY_ADAPTER_ENDPOINTS | ||
| python3 $BUNDLED_DEBUGPY_PATH --listen 0 --wait-for-client $argv | ||
| set -x DEBUGPY_ADAPTER_ENDPOINTS "$VSCODE_DEBUGPY_ADAPTER_ENDPOINTS" | ||
| python3 "$BUNDLED_DEBUGPY_PATH" --listen 0 --wait-for-client $argv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| # PowerShell script | ||
| $env:DEBUGPY_ADAPTER_ENDPOINTS = $env:VSCODE_DEBUGPY_ADAPTER_ENDPOINTS | ||
| $os = [System.Environment]::OSVersion.Platform | ||
| if ($os -eq [System.PlatformID]::Win32NT) { | ||
| python $env:BUNDLED_DEBUGPY_PATH --listen 0 --wait-for-client $args | ||
| } else { | ||
| python3 $env:BUNDLED_DEBUGPY_PATH --listen 0 --wait-for-client $args | ||
| } | ||
| # PowerShell script | ||
| $env:DEBUGPY_ADAPTER_ENDPOINTS = $env:VSCODE_DEBUGPY_ADAPTER_ENDPOINTS | ||
| $os = [System.Environment]::OSVersion.Platform | ||
| if ($os -eq [System.PlatformID]::Win32NT) { | ||
| python "$env:BUNDLED_DEBUGPY_PATH" --listen 0 --wait-for-client $args | ||
| } else { | ||
| python3 "$env:BUNDLED_DEBUGPY_PATH" --listen 0 --wait-for-client $args | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #! /bin/bash | ||
| # Bash script | ||
| export DEBUGPY_ADAPTER_ENDPOINTS="$VSCODE_DEBUGPY_ADAPTER_ENDPOINTS" | ||
| python3 "$BUNDLED_DEBUGPY_PATH" --listen 0 --wait-for-client "$@" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot generated:
Identical file duplication:
debugpy.shis byte-for-byte identical to the extensionlessdebugpyfile. There's no mechanism (symlink, build step, or even a comment) to keep them in sync. A future fix to one may miss the other.Suggested fix: Either (a) make
debugpy.sha symlink todebugpy, (b) add a prominent comment in both files stating they must stay synchronized, or (c) generate one from the other in a build/copy step.[verified]