selectBox: fix character navigation skipping last matching option#306579
Open
xingsy97 wants to merge 2 commits intomicrosoft:mainfrom
Open
selectBox: fix character navigation skipping last matching option#306579xingsy97 wants to merge 2 commits intomicrosoft:mainfrom
xingsy97 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes custom select box “type-to-select” behavior so character navigation checks all options (including the currently selected one), matching native <select> cycling semantics and avoiding no-op keypresses when the only match is at the previously skipped position.
Changes:
- Adjusted
SelectBoxList.onCharacter()loop bound to iteratethis.options.lengthtimes (instead ofthis.options.length - 1) so every candidate index is evaluated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SelectBoxList.onCharacter()mimics native<select>keyboard navigation: pressing a letter key should cycle through options whose text starts with that letter. The loop iteratesthis.options.length - 1times instead ofthis.options.length, so one candidate position is never checked. When the only remaining match is at the skipped position—typically the currently selected option after a full cycle—pressing the character key does nothing.Fix
Change the loop bound from
this.options.length - 1tothis.options.lengthso all positions are checked.