Skip flaky agent-sandbox integration test (non-allowlisted domains flow)#306589
Open
Skip flaky agent-sandbox integration test (non-allowlisted domains flow)#306589
Conversation
…confirmation flow) (#306588) Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/67d32e38-cbaa-45fc-9769-ee00aaf495dd Co-authored-by: dileepyavan <52841896+dileepyavan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Skip flaky integration test in agent-sandbox
Skip flaky agent-sandbox integration test (non-allowlisted domains flow)
Mar 31, 2026
dileepyavan
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Disables an intermittently failing agent-sandbox integration test in the VS Code API test suite by marking it as skipped, referencing the tracking issue for the flakiness.
Changes:
- Marked
non-allowlisted domains trigger unsandboxed confirmation flowastest.skip. - Added a
// Flaky: #306588annotation, matching the existing skip pattern in the same suite.
dileepyavan
reviewed
Mar 31, 2026
extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts
Outdated
Show resolved
Hide resolved
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/d00cca1e-2f77-48ee-b454-64ccbe6c86cf Co-authored-by: dileepyavan <52841896+dileepyavan@users.noreply.github.com>
dileepyavan
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
echo command returns exactly the echoed textin theshell integration off > sandbox offsuite// Flaky: #306588commentnon-allowlisted domains trigger unsandboxed confirmation flow