unicodeHighlighter: fix disable-in-comments and disable-in-strings actions using wrong command ID#306602
Open
xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
Open
unicodeHighlighter: fix disable-in-comments and disable-in-strings actions using wrong command ID#306602xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…tions using wrong command ID
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes command ID wiring for Unicode highlighter quick-fix actions so that “Disable highlighting in comments” and “Disable highlighting in strings” invoke their own commands instead of incorrectly sharing the ambiguous-characters command ID.
Changes:
- Update
DisableHighlightingInCommentsActionto useDisableHighlightingInCommentsAction.IDwhen callingsuper(...). - Update
DisableHighlightingInStringsActionto useDisableHighlightingInStringsAction.IDwhen callingsuper(...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
DisableHighlightingInCommentsActionandDisableHighlightingInStringsActiondefine their ownstatic IDbut passDisableHighlightingOfAmbiguousCharactersAction.IDtosuper(), causing all three actions to share one command ID. This means the 'Disable highlighting in comments' and 'Disable highlighting in strings' quick-fix actions silently execute the wrong command.Fix
Change both constructors to use their own
static ID.