Skip to content

unicodeHighlighter: fix disable-in-comments and disable-in-strings actions using wrong command ID#306602

Open
xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
xingsy97:wt/unicode-highlight-action-ids
Open

unicodeHighlighter: fix disable-in-comments and disable-in-strings actions using wrong command ID#306602
xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
xingsy97:wt/unicode-highlight-action-ids

Conversation

@xingsy97
Copy link
Copy Markdown
Member

Problem

Both DisableHighlightingInCommentsAction and DisableHighlightingInStringsAction define their own static ID but pass DisableHighlightingOfAmbiguousCharactersAction.ID to super(), causing all three actions to share one command ID. This means the 'Disable highlighting in comments' and 'Disable highlighting in strings' quick-fix actions silently execute the wrong command.

Fix

Change both constructors to use their own static ID.

Copilot AI review requested due to automatic review settings March 31, 2026 05:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes command ID wiring for Unicode highlighter quick-fix actions so that “Disable highlighting in comments” and “Disable highlighting in strings” invoke their own commands instead of incorrectly sharing the ambiguous-characters command ID.

Changes:

  • Update DisableHighlightingInCommentsAction to use DisableHighlightingInCommentsAction.ID when calling super(...).
  • Update DisableHighlightingInStringsAction to use DisableHighlightingInStringsAction.ID when calling super(...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants