Skip to content

snippets: fix disambiguation of completions with identical prefixes #306608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xingsy97 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

snippets: fix disambiguation of completions with identical prefixes #306608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class SnippetCompletionProvider implements CompletionItemProvider {
for (let i = 0; i < suggestions.length; i++) {
const item = suggestions[i];
let to = i + 1;
for (; to < suggestions.length && item.label === suggestions[to].label; to++) {
for (; to < suggestions.length && item.label.label === suggestions[to].label.label; to++) {
suggestions[to].label.label = localize('snippetSuggest.longLabel', "{0}, {1}", suggestions[to].label.label, suggestions[to].snippet.name);
Comment on lines +192 to 193
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes duplicate-prefix detection, but there doesn't appear to be test coverage asserting that multiple snippets with the same prefix get disambiguated (e.g. label becomes ", "). Consider adding a unit test in the existing snippetsService test suite that registers two snippets with the same prefix and asserts the resulting completion labels are distinct.

Copilot uses AI. Check for mistakes.
}
if (to > i + 1) {
Expand Down
Loading